Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Tweak voice broadcast live icon #9576

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Tweak voice broadcast live icon #9576

merged 1 commit into from
Nov 16, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Nov 14, 2022 •
edited by github-actions bot
Loading

Part of element-hq/element-web#23282

  • Grey „live“ state
  • Implement all display conditions

image

PSF-1610

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Nov 14, 2022
@weeman1337 weeman1337 force-pushed the weeman1337/voice-broadcast-live-icon branch from 4b00538 to 4debdb5 Compare November 16, 2022 08:13
@weeman1337 weeman1337 force-pushed the weeman1337/voice-broadcast-live-icon branch from 4debdb5 to 6af53f3 Compare November 16, 2022 08:40
@weeman1337 weeman1337 marked this pull request as ready for review November 16, 2022 08:58
@weeman1337 weeman1337 requested a review from a team as a code owner November 16, 2022 08:58
florianduros
florianduros approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@weeman1337 weeman1337 merged commit cf3c899 into develop Nov 16, 2022
@weeman1337 weeman1337 deleted the weeman1337/voice-broadcast-live-icon branch November 16, 2022 15:14
amywalkerdev pushed a commit that referenced this pull request Nov 28, 2022
@weeman1337
Tweak voice broadcast live icon (#9576)
a2f6dee
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@florianduros florianduros florianduros approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

@artcodespace artcodespace Awaiting requested review from artcodespace artcodespace is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weeman1337 @florianduros