Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add voice broadcast max length #9564

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Add voice broadcast max length #9564

merged 2 commits into from
Nov 10, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Nov 9, 2022 •
edited
Loading

Part of element-hq/element-web#23282

PSF-1656

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Nov 9, 2022
@weeman1337 weeman1337 force-pushed the weeman1337/voice-broadcast-max-length branch from c7dcc79 to a4435a1 Compare November 10, 2022 08:50
@weeman1337 weeman1337 force-pushed the weeman1337/voice-broadcast-max-length branch from a4435a1 to 5ce9adc Compare November 10, 2022 09:34
@weeman1337 weeman1337 force-pushed the weeman1337/voice-broadcast-max-length branch from 5ce9adc to 3f6aca3 Compare November 10, 2022 09:35
@weeman1337 weeman1337 marked this pull request as ready for review November 10, 2022 09:54
@weeman1337 weeman1337 requested a review from a team as a code owner November 10, 2022 09:54
@weeman1337 weeman1337 requested review from kerryarchibald, justjanne and florianduros and removed request for kerryarchibald November 10, 2022 09:54
germain-gg
germain-gg approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

res/img/element-icons/Timer.svg Outdated Show resolved Hide resolved
@weeman1337 weeman1337 enabled auto-merge (squash) November 10, 2022 10:40
@weeman1337 weeman1337 merged commit f6347d2 into develop Nov 10, 2022
@weeman1337 weeman1337 deleted the weeman1337/voice-broadcast-max-length branch November 10, 2022 10:53
@weeman1337 weeman1337 mentioned this pull request Nov 14, 2022
Closed
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

@florianduros florianduros Awaiting requested review from florianduros

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weeman1337 @germain-gg