Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Improve Voice Broadcast header layout #9437

Merged
merged 6 commits into from
Oct 17, 2022
Merged

Improve Voice Broadcast header layout #9437

merged 6 commits into from
Oct 17, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Oct 17, 2022 •
edited by github-actions bot
Loading

Part of element-hq/element-web#23282

  • Fix Live badge position
  • Prevent room name / broadcaster name overflow

Before

image

After

image

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 17, 2022
@weeman1337 weeman1337 requested a review from a team as a code owner October 17, 2022 14:09
kerryarchibald
kerryarchibald reviewed Oct 17, 2022
View reviewed changes
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2022-10-17 at 16 34 12

The tile overflows with a long room name

@kerryarchibald
Copy link
Contributor

The tile overflows with a long room name

This is not caused by this PR, so not blocking.

@weeman1337
Copy link
Contributor Author

Screenshot 2022-10-17 at 16 34 12

The tile overflows with a long room name

Thanks for finding this. Will include a fix for that…

@weeman1337 weeman1337 changed the title Fix Voice Broadcast live badge position Improve Voice Broadcast header layout Oct 17, 2022
@weeman1337 weeman1337 enabled auto-merge (squash) October 17, 2022 14:57
kerryarchibald
kerryarchibald approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2022-10-17 at 16 57 33

@t3chguy t3chguy disabled auto-merge October 17, 2022 16:12
@t3chguy
Copy link
Member

t3chguy commented Oct 17, 2022

Force merging due to wedged test

@t3chguy t3chguy merged commit e1d631c into develop Oct 17, 2022
@t3chguy t3chguy deleted the weeman1337/fix-voice-broadcast-layout branch October 17, 2022 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robintown robintown robintown approved these changes

@kerryarchibald kerryarchibald kerryarchibald approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weeman1337 @kerryarchibald @t3chguy @robintown