Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Voice Broadcast live state / extract RelationsHelper #9432

Merged
merged 4 commits into from
Oct 17, 2022
Merged

Voice Broadcast live state / extract RelationsHelper #9432

merged 4 commits into from
Oct 17, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Oct 17, 2022 •
edited by github-actions bot
Loading

Part of element-hq/element-web#23282

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 17, 2022
@weeman1337 weeman1337 changed the title Extract RelationsHelper Voice Broadcast live state / extract RelationsHelper Oct 17, 2022
@weeman1337 weeman1337 marked this pull request as ready for review October 17, 2022 11:35
@weeman1337 weeman1337 requested a review from a team as a code owner October 17, 2022 11:35
kerryarchibald
kerryarchibald approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nitpick about strict typing

src/events/RelationsHelper.ts Outdated Show resolved Hide resolved
@weeman1337 weeman1337 enabled auto-merge (squash) October 17, 2022 12:07
@t3chguy t3chguy disabled auto-merge October 17, 2022 12:30
@t3chguy
Copy link
Member

t3chguy commented Oct 17, 2022

Force merging due to flaky test

@t3chguy t3chguy merged commit 1b74782 into develop Oct 17, 2022
@t3chguy t3chguy deleted the weeman1337/relations-helper branch October 17, 2022 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kerryarchibald kerryarchibald kerryarchibald approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

@duxovni duxovni Awaiting requested review from duxovni duxovni is a code owner automatically assigned from matrix-org/element-web-reviewers

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weeman1337 @t3chguy @kerryarchibald