Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Update voice broadcast header to new design #9415

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Update voice broadcast header to new design #9415

merged 3 commits into from
Oct 14, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Oct 13, 2022 •
edited by github-actions bot
Loading

Part of element-hq/element-web#23282

New:

  • The header should always show the room avatar + name
  • The line with the 🎙️ should show the sender name

Designs: https://www.figma.com/file/5zlCPsSOJELBzIiQdHC2LV/Voice-Broadcasting?node-id=17%3A9566

image

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 13, 2022
@weeman1337 weeman1337 force-pushed the weeman1337/voice-broadcast-header branch 2 times, most recently from 92c5a89 to 42fe121 Compare October 13, 2022 19:03
@weeman1337 weeman1337 force-pushed the weeman1337/voice-broadcast-header branch from 42fe121 to 607f0dd Compare October 14, 2022 06:28
@weeman1337 weeman1337 marked this pull request as ready for review October 14, 2022 06:29
@weeman1337 weeman1337 requested a review from a team as a code owner October 14, 2022 06:29
@weeman1337 weeman1337 enabled auto-merge (squash) October 14, 2022 06:29
germain-gg
germain-gg approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙏

@weeman1337 weeman1337 merged commit bbb02c3 into develop Oct 14, 2022
@weeman1337 weeman1337 deleted the weeman1337/voice-broadcast-header branch October 14, 2022 08:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@duxovni duxovni Awaiting requested review from duxovni duxovni is a code owner automatically assigned from matrix-org/element-web-reviewers

@SimonBrandner SimonBrandner Awaiting requested review from SimonBrandner SimonBrandner is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weeman1337 @germain-gg