Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Extract useVoiceBroadcastRecording hook #9406

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Extract useVoiceBroadcastRecording hook #9406

merged 2 commits into from
Oct 13, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Oct 13, 2022 •
edited by github-actions bot
Loading

Part of element-hq/element-web#23282

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 13, 2022
@weeman1337 weeman1337 force-pushed the weeman1337/voice-broadcast-recording-hook branch 2 times, most recently from c542421 to 17a098c Compare October 13, 2022 08:43
@weeman1337 weeman1337 force-pushed the weeman1337/voice-broadcast-recording-hook branch from 17a098c to b166402 Compare October 13, 2022 09:34
@weeman1337 weeman1337 marked this pull request as ready for review October 13, 2022 10:00
@weeman1337 weeman1337 requested a review from a team as a code owner October 13, 2022 10:00
kerryarchibald
kerryarchibald approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weeman1337 weeman1337 enabled auto-merge (squash) October 13, 2022 11:49
@t3chguy t3chguy disabled auto-merge October 13, 2022 12:02
@t3chguy t3chguy merged commit 7a1c47a into develop Oct 13, 2022
@t3chguy t3chguy deleted the weeman1337/voice-broadcast-recording-hook branch October 13, 2022 12:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kerryarchibald kerryarchibald kerryarchibald approved these changes

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from matrix-org/element-web-reviewers

@SimonBrandner SimonBrandner Awaiting requested review from SimonBrandner SimonBrandner is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weeman1337 @kerryarchibald @t3chguy