Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add MessageEvent voice broadcast setting watch #9399

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Add MessageEvent voice broadcast setting watch #9399

merged 1 commit into from
Oct 12, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Oct 12, 2022 •
edited
Loading

Part of element-hq/element-web#23282

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 12, 2022
@weeman1337 weeman1337 force-pushed the weeman1337/voice-broadcast-messsage-setting branch from 572d34b to a69afaa Compare October 12, 2022 15:40
@weeman1337 weeman1337 force-pushed the weeman1337/voice-broadcast-messsage-setting branch from a69afaa to 7a1e1c9 Compare October 12, 2022 16:10
@weeman1337 weeman1337 marked this pull request as ready for review October 12, 2022 16:32
@weeman1337 weeman1337 requested a review from a team as a code owner October 12, 2022 16:32
@weeman1337 weeman1337 enabled auto-merge (squash) October 12, 2022 16:38
turt2live
turt2live approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a number of code quality concerns in what appears to be prior PRs on this feature, however the diff here is acceptable.

We'll need to revist a lot of this feature soon to bring it back up to par.

@weeman1337 weeman1337 merged commit cd80642 into develop Oct 12, 2022
@weeman1337 weeman1337 deleted the weeman1337/voice-broadcast-messsage-setting branch October 12, 2022 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@turt2live turt2live turt2live approved these changes

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

@duxovni duxovni Awaiting requested review from duxovni duxovni is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weeman1337 @turt2live