Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Hide voice broadcast chunks #9397

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Oct 12, 2022

Part of element-hq/element-web#23282

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 12, 2022
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(Couldn't really figure out how to test on the deployment, after starting a live I never saw any chunks. Is there more than one flag I need to enabled?)

@weeman1337
Copy link
Contributor Author

Couldn't really figure out how to test on the deployment, after starting a live I never saw any chunks. Is there more than one flag I need to enabled?

@kerryarchibald watch out for the microphone request (if any). There is nothing in place yet, that handles if you reject access to it. Clicking the tile again should immediately send the remaining chunk.

@weeman1337 weeman1337 merged commit b871456 into develop Oct 12, 2022
@weeman1337 weeman1337 deleted the weeman1337/hide-voice-broadcast-chunks branch October 12, 2022 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants