Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Include device_id in voice broadcast info events #9394

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Include device_id in voice broadcast info events #9394

merged 1 commit into from
Oct 12, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Oct 12, 2022 •
edited by github-actions bot
Loading

Part of element-hq/element-web#23282

See element-hq/element-meta#632

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 12, 2022
@weeman1337 weeman1337 marked this pull request as ready for review October 12, 2022 09:38
@weeman1337 weeman1337 requested a review from a team as a code owner October 12, 2022 09:38
kerryarchibald
kerryarchibald approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weeman1337 weeman1337 merged commit 19bc3f1 into develop Oct 12, 2022
@weeman1337 weeman1337 deleted the weeman1337/voice-broadcast-info-deviceid branch October 12, 2022 11:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kerryarchibald kerryarchibald kerryarchibald approved these changes

@turt2live turt2live Awaiting requested review from turt2live turt2live is a code owner automatically assigned from matrix-org/element-web-reviewers

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

@duxovni duxovni Awaiting requested review from duxovni duxovni is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weeman1337 @kerryarchibald