Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Extract voice broadcast header #9393

Merged
merged 4 commits into from
Oct 12, 2022
Merged

Extract voice broadcast header #9393

merged 4 commits into from
Oct 12, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Oct 12, 2022 •
edited
Loading

Part of element-hq/element-web#23282

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Oct 12, 2022
@weeman1337 weeman1337 force-pushed the weeman1337/voice-broadcast-header branch from 8e3f829 to bdaec6d Compare October 12, 2022 08:59
@weeman1337 weeman1337 marked this pull request as ready for review October 12, 2022 09:18
@weeman1337 weeman1337 requested a review from a team as a code owner October 12, 2022 09:18
kerryarchibald
kerryarchibald reviewed Oct 12, 2022
View reviewed changes
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the non-compound spacing variable.

res/css/_spacing.pcss Outdated Show resolved Hide resolved
test/voice-broadcast/components/atoms/VoiceBroadcastHeader-test.tsx Show resolved Hide resolved
@weeman1337 weeman1337 enabled auto-merge (squash) October 12, 2022 13:26
@weeman1337 weeman1337 merged commit 533eda2 into develop Oct 12, 2022
@weeman1337 weeman1337 deleted the weeman1337/voice-broadcast-header branch October 12, 2022 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kerryarchibald kerryarchibald kerryarchibald approved these changes

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from matrix-org/element-web-reviewers

@turt2live turt2live Awaiting requested review from turt2live turt2live is a code owner automatically assigned from matrix-org/element-web-reviewers

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weeman1337 @kerryarchibald