Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Implement GroupCallUtils #9131

Merged
merged 5 commits into from
Aug 10, 2022
Merged

Implement GroupCallUtils #9131

merged 5 commits into from
Aug 10, 2022

Conversation

weeman1337
Copy link
Contributor

@weeman1337 weeman1337 commented Aug 4, 2022

Closes element-hq/element-web#22957


This change is marked as an internal change (Task), so will not be included in the changelog.

@weeman1337 weeman1337 added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 4, 2022
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have only looked through the tests more briefly but looks awesome - thank you!

src/utils/GroupCallUtils.ts Show resolved Hide resolved
src/utils/GroupCallUtils.ts Outdated Show resolved Hide resolved
src/utils/GroupCallUtils.ts Outdated Show resolved Hide resolved
src/utils/GroupCallUtils.ts Outdated Show resolved Hide resolved
src/utils/GroupCallUtils.ts Show resolved Hide resolved
test/utils/GroupCallUtils-test.ts Outdated Show resolved Hide resolved
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, awesome, those are some very extensive tests

@weeman1337 weeman1337 merged commit 9ed5550 into develop Aug 10, 2022
@weeman1337 weeman1337 deleted the weeman1337/group-call-utils branch August 10, 2022 06:51
kerryarchibald pushed a commit that referenced this pull request Aug 10, 2022
* Implement GroupCallUtils

* Trigger CI

* Use UnstableValue for new call event types

* Implement PR feedback
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port VideoChannelUtils to MSC3401
3 participants