Fixes right panel composer look and feel #8783
Conversation
germain-gg
added
the
T-Defect
|
|
|
@DoM1niC I'm not sure I can reproduce that. I'd recommend you open a ticket describing steps to reproduce |
There was a problem hiding this comment.
Nice, I think a couple of more tweaks help the composer fit more into the right panel.
.mx_MessageComposer_row padding: 8px 12px
this makes the composer a bit shorter by default so it fits better into the smaller space, although it does seems to make the action icons jump around a bit in the screenshot below.
Content:
I'm not sure if this was implemented but in the Threads designs, the hint was "Reply to thread" not the same as the default composer hint "Send encrypted message..." - if that was implemented, can it return please? It gives user more context.
Border-colour: please could we remove the focus colour border change for now, while gathering more feedback? I think it makes the composer fit more naturally next to it's icons which is more noticeable on the threads
|
Why not simply using flex align-items: center, removing all of the block margin in pixel values around there, because flexbox model is intended to be used for ensuring the same height for all of the elements inside it? For example, of my closed PR: pull/8799/commits/d5b5ef93ed911ca7d7ace521364360798cea52e5 |
turt2live
added
the
X-Blocked
|
blocked on future of the composer |
|
@DoM1niC it was very easy to reproduce the issue, and the issue was logged here: element-hq/element-web#22508
|
Fixes element-hq/element-web#22459
I removed the top outline on the reply preview container as the composer is already in a box when used in that container and the border radius used there does not match the border radius of the outer container.
Here's what your changelog entry will look like:
🐛 Bug Fixes