Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Remove unnecessary ButtonResetDefault from mx_LeftPanelLiveShareWarning #8761

Merged
merged 2 commits into from
Jun 5, 2022
Merged

Remove unnecessary ButtonResetDefault from mx_LeftPanelLiveShareWarning #8761

merged 2 commits into from
Jun 5, 2022

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jun 5, 2022

ButtonResetDefault has not been necessary for the button.

Before After
before after
after

Signed-off-by: Suguru Hirahara [email protected]

type: task


This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jun 5, 2022
@luixxiul luixxiul marked this pull request as ready for review June 5, 2022 11:58
@luixxiul luixxiul requested a review from a team as a code owner June 5, 2022 11:58
@SimonBrandner SimonBrandner enabled auto-merge (squash) June 5, 2022 13:06
@SimonBrandner
Copy link
Contributor

SimonBrandner commented Jun 5, 2022

Could you please try merging develop? - the Enforce Labels check is failing and from what I gather this could help

@luixxiul luixxiul disabled auto-merge June 5, 2022 13:15
@luixxiul
Copy link
Contributor Author

luixxiul commented Jun 5, 2022

umm I get nothing to fire that action...

Screenshot_2022-06-05_13-16-20

@SimonBrandner
Copy link
Contributor

There should be new code on develop now :)

@SimonBrandner SimonBrandner enabled auto-merge (squash) June 5, 2022 13:28
@SimonBrandner SimonBrandner merged commit 022535e into matrix-org:develop Jun 5, 2022
@luixxiul luixxiul deleted the LeftPanelLiveShareWarning branch June 5, 2022 13:40
JanBurp pushed a commit to JanBurp/matrix-react-sdk that referenced this pull request Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants