This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Include GifPicker for chat #8712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create Popup window
- Load Gifs on scroll - Implement Search bar - Add "Powered by Giphy"
|
Hi, |
|
Thank you for working on this, however per element-hq/element-meta#321 (comment) I don't think we can safely keep this sort of change open. The feature requires design and product review and is generally quite large in size - we might try to take the work on ourselves if/when product/design get a chance to take a look. |
MadLittleMods
added
Z-Community-PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: element-hq/element-meta#321
Similar PR: #5814
Implementation of a Gif Picker.
It sends the gif directly, an alternative would be to just send the URL and the clients render it. This solution would reduce used storage space and could be extended to support different services but it comes with the problem that when the gif is deleted the client cant display it anymore.
TODO
Signed-off-by: Alexander Neuhäuser [email protected]
Here's what your changelog entry will look like:
✨ Features