Set margin between "Forgot passwords?" and SSO buttons

[luixxiul]

Fixes element-hq/element-web#21545

Signed-off-by: Suguru Hirahara [email protected]

after.mp4

type: defect

---

Here's what your changelog entry will look like:

🐛 Bug Fixes

• Set margin between "Forgot passwords?" and SSO buttons (#8143). Fixes Margin between "Forgot password?" and SSO buttons element-hq/element-web#21545. Contributed by @luixxiul.

Preview: https://pr8143--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

[codecov]

Codecov Report

Merging #8143 (d9907fe) into develop (61076c3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #8143   +/-   ##
========================================
  Coverage    29.25%   29.25%           
========================================
  Files          863      863           
  Lines        49876    49876           
  Branches     12696    12696           
========================================
  Hits         14592    14592           
  Misses       35284    35284           

[turt2live]

hmm, maintaining either the button itself or moving the spinner above the SSO buttons would probably be best - both before and after this bug it's far too easy to double click and end up in a bad spot.

Passing off to design before code review.

[luixxiul]

This case #8163 should just be reopened to fix the issue.

[janogarcia]

Thanks @luixxiul, but I agree with @turt2live remarks. The correct way to handle it would be to use a busy state for the button (disabled button, loading spinner inside), so there are no UI reflows / layout shifts involved.

Two questions for @turt2live:

• Do we have such a busy state already that we can reuse?
• This shouldn't be on the contributor's plate if not interested / can't contribute it. In that case, should we just close this PR without merging?

[luixxiul]

The correct way to handle it would be to use a busy state for the button (disabled button, loading spinner inside), so there are no UI reflows / layout shifts involved.

I would totally agree 👍

[turt2live]

• Do we have such a busy state already that we can reuse?

We have a disabled state, yea. Should be easy to copy.

• This shouldn't be on the contributor's plate if not interested / can't contribute it. In that case, should we just close this PR without merging?

Yup, though they've done so from the looks of it ;)

[luixxiul]

#8163 has been closed in favor of this. That should be reopened. It should realize element-hq/element-web#21545 (comment)