Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Wire up drag-drop file uploads for the thread view #7860

Merged
merged 15 commits into from
Feb 22, 2022
Merged

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Feb 21, 2022

Fixes element-hq/element-web#19578
Also fixes issue where the attachment button in the composer overflow menu left the menu hanging around when you're picking a file.

image

(fixed the missing border radius, too lazy to take another screenshot)


This PR currently has no changelog labels, so will not be included in changelogs.

Add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is plus X-Breaking-Change if it's a breaking change.

Preview: https://pr7860--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@t3chguy t3chguy requested a review from a team as a code owner February 21, 2022 16:37
@t3chguy
Copy link
Member Author

t3chguy commented Feb 21, 2022

(I cannot replicate these test failures locally, so having to play a game of whack-a-mole)

Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great stuff making the drop zone a bit more generic than it used to be 👏

… t3chguy/fix/19578

� Conflicts:
�	src/components/structures/RoomView.tsx
@t3chguy t3chguy enabled auto-merge (squash) February 22, 2022 11:06
@t3chguy t3chguy merged commit 8fccef8 into develop Feb 22, 2022
@t3chguy t3chguy deleted the t3chguy/fix/19578 branch February 22, 2022 11:14
@janogarcia
Copy link
Contributor

@t3chguy Awesome! 👏

(I was about to report the sharp inner corners bug and then saw your comment :D)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make files drag and drop file in a room work with threads
3 participants