Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix video call container size inconsistencies #7170

Merged
merged 4 commits into from
Nov 23, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion res/css/views/rooms/_AppsDrawer.scss
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ limitations under the License.
$MiniAppTileHeight: 200px;

.mx_AppsDrawer {
margin: 5px 5px 5px 13px;
margin: 5px;
margin-bottom: 0; // No bottom margin for the correct gap to the CallView below.
margin-left: 13px; // 5+8px to compensate for the scroll bar padding on the right.
position: relative;
display: flex;
flex-direction: column;
Expand Down
6 changes: 5 additions & 1 deletion res/css/views/voip/_CallView.scss
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,18 @@ limitations under the License.

.mx_CallView_large {
padding-bottom: 10px;
margin: 5px 5px 5px 18px;
margin: 5px 5px 5px 13px;
display: flex;
flex-direction: column;
flex: 1;

.mx_CallView_voice {
flex: 1;
}

&.mx_CallView_belowWidget {
margin-top: 0;
}
}

.mx_CallView_pip {
Expand Down
1 change: 1 addition & 0 deletions src/components/views/rooms/AuxPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ export default class AuxPanel extends React.Component<IProps, IState> {
<CallViewForRoom
roomId={this.props.room.roomId}
resizeNotifier={this.props.resizeNotifier}
showApps={this.props.showApps}
/>
);

Expand Down
11 changes: 9 additions & 2 deletions src/components/views/voip/CallView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ interface IProps {

// Used for dragging the PiP CallView
onMouseDownOnHeader?: (event: React.MouseEvent<Element, MouseEvent>) => void;

showApps?: boolean;
}

interface IState {
Expand Down Expand Up @@ -614,9 +616,14 @@ export default class CallView extends React.Component<IProps, IState> {
);
}

const myClassName = this.props.pipMode ? 'mx_CallView_pip' : 'mx_CallView_large';
const callViewClasses = classNames({
mx_CallView: true,
mx_CallView_pip: this.props.pipMode,
mx_CallView_large: !this.props.pipMode,
mx_CallView_belowWidget: this.props.showApps, // css to correct the margins if the call is below the AppsDrawer.
});

return <div className={"mx_CallView " + myClassName}>
return <div className={callViewClasses}>
<CallViewHeader
onPipMouseDown={this.props.onMouseDownOnHeader}
pipMode={this.props.pipMode}
Expand Down
3 changes: 3 additions & 0 deletions src/components/views/voip/CallViewForRoom.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ interface IProps {
roomId: string;

resizeNotifier: ResizeNotifier;

showApps?: boolean;
}

interface IState {
Expand Down Expand Up @@ -121,6 +123,7 @@ export default class CallViewForRoom extends React.Component<IProps, IState> {
<CallView
call={this.state.call}
pipMode={false}
showApps={this.props.showApps}
/>
</Resizable>
</div>
Expand Down