Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Replace emoticons when sending a message rather than when typing #6718

Closed

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Aug 31, 2021

Fixes element-hq/element-web#18833
Type: enhancement


This is a Discord-like behaviour


Peek.2021-08-31.18-45.mp4

Reasoning in in element-hq/element-web#18833 (comment)


Here's what your changelog entry will look like:

✨ Features

Preview: https://612e5de04963753ad92439b6--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@SimonBrandner SimonBrandner requested a review from a team as a code owner August 31, 2021 16:47
@github-actions github-actions bot added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Aug 31, 2021
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine, though the behaviour change is fairly dramatic. It's actually quite annoying when other apps (Messenger, certain email clients, etc) replace on send as what you carefully curated your keystrokes for gets mangled by the app, losing confidence that what you type is what will be sent.

In the short term, there's an advanced (and confusing) setting for autocomplete delay: I'd try raising that a bit and seeing how that feels so we can consider possibly changing the default value there.

@turt2live turt2live requested a review from a team September 1, 2021 20:47
@SimonBrandner
Copy link
Contributor Author

It's actually quite annoying when other apps (Messenger, certain email clients, etc) replace on send as what you carefully curated your keystrokes for gets mangled by the app, losing confidence that what you type is what will be sent.

I tend to prefer this since it's consistent with the emoticon at the end of the line. See element-hq/element-web#18833 (comment). I can create a PR that does the alternative mentioned in the issue.

In the short term, there's an advanced (and confusing) setting for autocomplete delay: I'd try raising that a bit and seeing how that feels so we can consider possibly changing the default value there.

Sorry, I don't think this relates much. Since the autocomplete changes we never autocomplete emoticons (:D, :)), we only autocomplete emoji shortcodes (:smile:, :heart:), so I am not sure how would this apply

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should consider converting emoticons to emoji when sending rather than when typing
2 participants