This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Tweak leave space dialog texts to be more informative #6709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweak the "don't leave any" text to be more informative. Add some context to the radio button list to tell the user what they're actually making a choice about.
SimonBrandner
added
the
T-Enhancement
|
I think this was already tackled in some other PR based on changes, so closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel that the leave space dialog didn't provide much context on what the user is making a choice about. Even though #6697 fixed a major pain point in accidentally leaving lots of rooms, the dialog has many problems imho regarding understanding what is being done. The default option no longer sits in to make it sound like natural English (previously "Don't leave any" was after "Leave all rooms and spaces", but having switched it no longer reads naturally).
Additionally, the question we are asking is "Do you want to leave?" but the radio buttons are not explained in any way, so I'm proposing adding a clarifying sentence.
Here's what your changelog entry will look like:
✨ Features
Preview: https://612caee06c68e4e051240eb6--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.