Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Display subspaces in minimized space panel #6555

Closed
wants to merge 4 commits into from

Conversation

robintown
Copy link
Member

@robintown robintown commented Aug 5, 2021

Screenshot 2021-08-04 at 23-19-55 Element off-topic

There's definitely room for improvement to make the layout more readable, but I hope this should be a good enough start for design to be able to provide feedback on.

Closes element-hq/element-web#17472.

Preview: https://611a88fe1baa5c009fa5d77b--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@robintown robintown requested a review from a team as a code owner August 5, 2021 04:01
Signed-off-by: Robin Townsend <[email protected]>
@t3chguy t3chguy requested a review from a team August 5, 2021 08:23
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine, though personally I'm not sure I'd be using this functionality. Subspaces are useful for organizing massive collections of rooms, but in practice I (personally) rarely ever actually jump into a subspace.

For metrics: Element's company space is ~40-50 subspaces with up to 4 levels deep of subspaces. I only really go digging through the tree if I'm looking for a particular room, but otherwise I'm just looking to filter by coarse area as a sort of account switching.

@nadonomy
Copy link
Contributor

nadonomy commented Aug 5, 2021

Hey @robintown thanks for the contribution. We'll need to review/think on this somewhat internally before accepting this.

One of the goals we set ourselves with Spaces was that we want to meet peoples expectations from other platforms and abstract away more complex capabilities. This resolves into ensuring the non-expanded state of the space panel being no more complex than peoples expectations from incumbents today.

I can absolutely see the value in this for committed users. It might be that we'd consider this behind a settings flag instead, but we'll discuss more internally and follow up!

@robintown
Copy link
Member Author

@nadonomy Good to know, and of course if this ultimately isn't desired functionality for mainline Element I'll definitely understand.

To add my two cents, the main reason for me suggesting this functionality is this: A number of my spaces are organized under personal spaces by their general topic, as is visible in the screenshot above. However, I rarely find myself wanting to view things from the perspective of the topic spaces, as they end up mixing together many separate, though related, subjects. So instead, I end up having to keep the space panel expanded all the time in order to be able to actually visit subspaces and see subspace-level notification states (as activity in one subspace might be a lot more important to me than activity in another).

Given @turt2live's comments this does sound like the sort of thing that might work best under a settings flag, though I'll wait to see what comes out of the internal discussion. 👍

@robintown
Copy link
Member Author

I'm retracting this PR since it seems from the recent IA things that the design team has other plans for subspaces anyways, which I'd rather not get in the way of :)

@robintown robintown closed this Nov 15, 2021
@niquewoodhouse
Copy link
Contributor

Hey @robintown

I'm retracting this PR since it seems from the recent IA things that the design team has other plans for subspaces anyways, which I'd rather not get in the way of :)

Just to say the team is not necessarily following through on any other plans at the moment. I think there's value in what you're proposing, and the issue it closes has a lot of useful ideas/feedback too. Lots of promise here.

We just need to find time later to focus on this specific interaction so we'll keep this in mind when we get to it. This will be of use then, so leaving it assigned to myself for then.

@robintown robintown reopened this Nov 28, 2021
@robintown robintown marked this pull request as draft May 10, 2022 21:12
@langleyd langleyd closed this Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View subspaces while the Spaces-bar is minimised.
5 participants