This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add alias and directory customisation points #6343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow environments such as P2P to tweak the preferred display alias if needed.
This will help certain environments, such as P2P, where directory publishing can be allowed freely.
turt2live
approved these changes
Jul 11, 2021
| @@ -24,6 +24,8 @@ limitations under the License. | |||
|
|
|||
| background-color: $togglesw-off-color; | |||
| opacity: 0.5; | |||
|
|
|||
| cursor: unset; | |||
There was a problem hiding this comment.
where is the cursor being set from when disabled? It feels like this is the wrong place to be disabling it if it's showing up from somewhere else.
Also, this feels unrelated?
There was a problem hiding this comment.
where is the cursor being set from when disabled? It feels like this is the wrong place to be disabling it if it's showing up from somewhere else.
Every ToggleSwitch is wrapped in AccessibleButton, and AB sets cursor: pointer as a base. Perhaps a better fix though is to apply the AB disabled class as well when disabled...?
Also, this feels unrelated?
Yeah, fair enough, just happened to notice it because the room directory publish setting is toggle. I'll remove from here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are useful for alternative environments, such as P2P, where alias and directory handling expectations are a bit different.