Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Use sleep & defer from js-sdk instead of duplicating it #6305

Merged
merged 4 commits into from
Jul 2, 2021
Merged

Use sleep & defer from js-sdk instead of duplicating it #6305

merged 4 commits into from
Jul 2, 2021

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jul 1, 2021 •
edited
Loading

@t3chguy t3chguy changed the title Convert EventTimeline, EventTimelineSet and TimelineWindow to TS Use defer from js-sdk as it has a better ts definition Jul 1, 2021
@t3chguy t3chguy requested a review from a team July 1, 2021 21:55
@t3chguy t3chguy changed the title Use defer from js-sdk as it has a better ts definition Use sleep & defer from js-sdk instead of duplicating it Jul 1, 2021
germain-gg
germain-gg reviewed Jul 2, 2021
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Base automatically changed from t3chguy/ts/10 to develop July 2, 2021 08:52
@t3chguy t3chguy merged commit 3287d3d into develop Jul 2, 2021
@t3chguy t3chguy deleted the t3chguy/ts/11 branch July 2, 2021 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@germain-gg germain-gg germain-gg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @germain-gg