Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Convert Markdown to TypeScript #6303

Merged
merged 3 commits into from
Jul 1, 2021
Merged

Convert Markdown to TypeScript #6303

merged 3 commits into from
Jul 1, 2021

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jul 1, 2021

and generally fix lint errors

@dbkr dbkr force-pushed the dbkr/tsify_markdown branch from 051a15c to e6b754f Compare July 1, 2021 19:41
@dbkr dbkr requested a review from a team July 1, 2021 19:53
@dbkr dbkr marked this pull request as ready for review July 1, 2021 19:53
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of missing types which should be easily plucked from @types/commonmark which needs installing, there's a bunch more missing but didn't comment on them all

src/Markdown.ts Show resolved Hide resolved
src/Markdown.ts Outdated Show resolved Hide resolved
src/Markdown.ts Outdated Show resolved Hide resolved
src/Markdown.ts Outdated Show resolved Hide resolved
@dbkr dbkr requested a review from t3chguy July 1, 2021 20:38
src/Markdown.ts Outdated Show resolved Hide resolved
src/Markdown.ts Outdated Show resolved Hide resolved
src/Markdown.ts Outdated Show resolved Hide resolved
src/Markdown.ts Outdated Show resolved Hide resolved
src/Markdown.ts Outdated Show resolved Hide resolved
Co-authored-by: Michael Telatynski <[email protected]>
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dbkr dbkr merged commit f965536 into develop Jul 1, 2021
@@ -54,6 +54,7 @@
},
"dependencies": {
"@babel/runtime": "^7.12.5",
"@types/commonmark": "^0.27.4",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to move this to dev deps to match the others.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants