This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Migrate FilePanel to TypeScript #6283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
approved these changes
Jun 29, 2021
| import { EventTimelineSet } from "matrix-js-sdk/src/models/event-timeline-set"; | ||
| import { MatrixEvent, Room } from 'matrix-js-sdk/src'; | ||
| import { TimelineWindow } from 'matrix-js-sdk/src/timeline-window'; | ||
|
|
||
| import * as sdk from '../../index'; |
There was a problem hiding this comment.
would be good to kill this off during this conversion imo
There was a problem hiding this comment.
As far as I'm aware it's still needed for tests sometimes?
Under what circumstances is it acceptable to remove?
There was a problem hiding this comment.
Well this'll be for the getComponent calls below, my point was we can probably eradicate them by switching to type-safe imports
Co-authored-by: Michael Telatynski <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated as part of my investigation for element-hq/element-web#17753
Requires #6283