-
-
Notifications
You must be signed in to change notification settings - Fork 829
Conversation
Signed-off-by: Aaron Raimist <[email protected]>
Signed-off-by: Aaron Raimist <[email protected]>
CI failure seems unrelated to these changes |
Could you maybe pull and merge the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, these all seem reasonable to me! 😄
@aaronraimist Does it actually require the JS SDK side...? |
Goes with the JS PR is probably a better way to put it, probably doesn’t require it |
@aaronraimist Could you resolve the conflict that has appeared here? |
Done |
@jryans does anything else need to happen here? |
Ah no, looks good. 😄 Sorry, I check my review queue more often than general GH notifications, so re-requesting review is a faster way for me notice things. Perhaps I need to change my notifications workflow again... 😅 |
Fixes element-hq/element-web#16018
Requires matrix-org/matrix-js-sdk#1754