Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Do not honor string power levels #6245

Merged
merged 5 commits into from
Jul 12, 2021
Merged

Conversation

aaronraimist
Copy link
Contributor

@aaronraimist aaronraimist commented Jun 23, 2021

Signed-off-by: Aaron Raimist <[email protected]>
@aaronraimist
Copy link
Contributor Author

CI failure seems unrelated to these changes

@turt2live turt2live requested a review from a team June 23, 2021 06:32
@germain-gg
Copy link
Contributor

CI failure seems unrelated to these changes

Could you maybe pull and merge the latest develop into this branch and that should fix the CI failure you experienced?
Apologies about that, it appears that something unexpected landed in develop and the CI is a bit too rigid

Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these all seem reasonable to me! 😄

@jryans
Copy link
Collaborator

jryans commented Jun 24, 2021

@aaronraimist Does it actually require the JS SDK side...?

@aaronraimist
Copy link
Contributor Author

Goes with the JS PR is probably a better way to put it, probably doesn’t require it

@jryans
Copy link
Collaborator

jryans commented Jun 28, 2021

@aaronraimist Could you resolve the conflict that has appeared here?

@aaronraimist
Copy link
Contributor Author

Done

@aaronraimist
Copy link
Contributor Author

@jryans does anything else need to happen here?

@jryans
Copy link
Collaborator

jryans commented Jul 12, 2021

Ah no, looks good. 😄

Sorry, I check my review queue more often than general GH notifications, so re-requesting review is a faster way for me notice things. Perhaps I need to change my notifications workflow again... 😅

@jryans jryans merged commit 1b39dbd into matrix-org:develop Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String PLs are treated as if they were ints
3 participants