This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Migrate some dialogs to TypeScript #6185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
approved these changes
Jun 14, 2021
src/components/views/dialogs/security/SetupEncryptionDialog.tsx
Outdated
Show resolved
Hide resolved
src/components/views/dialogs/security/CreateCrossSigningDialog.tsx
Outdated
Show resolved
Hide resolved
src/components/views/dialogs/security/CreateCrossSigningDialog.tsx
Outdated
Show resolved
Hide resolved
src/components/views/dialogs/security/CreateCrossSigningDialog.tsx
Outdated
Show resolved
Hide resolved
| @@ -269,7 +269,7 @@ export default class Registration extends React.Component<IProps, IState> { | |||
| ); | |||
| } | |||
|
|
|||
| private onUIAuthFinished = async (success, response, extra) => { | |||
| private onUIAuthFinished = async (success, response) => { | |||
There was a problem hiding this comment.
I followed the trail for response and it's set as any in js-sdk
jryans
added a commit
that referenced
this pull request
Jun 18, 2021
#6185 converted `SetupEncryptionStore` to TS, including moving the phase states to an enum. The calling JS modules were forgotten, so they got a bit confused. Fixes element-hq/element-web#17689 Regressed by #6185
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.