Add message bubbles

[su-ex]

Related to element-hq/element-web#4635

Screenshots

Signed-off-by: Quirin Götz [email protected]

[SimonBrandner]

I didn't have the time to go through everything but generally, this looks awesome! Just some minor things and questions. Thank you! 🚀

The stuff with the prefixes is probably up to the team.

And feel free to scream, if my suggestions don't make sense 😅

Edit: Also, regarding the curly braces... we've settled on { foo, bar }, instead of {foo, bar} for objects but a rule for the react-sdk hasn't been setup yet

[SimonBrandner]

This would probably be for the second part of the review. I haven't made myself review the EventTile.tsx and _BubbleLayout.scss changes yet, but I think we should probably first decide on the things like the prefixes

[SimonBrandner]

I am probably totally overlooking where this is used

[su-ex]

Once a build failed if singleSideBubbles wasn't there. Recently I noticed that adaptiveSideBubbles was missing and added it just in case. But I have absolutely no clue why this is needed either.

[SimonBrandner]

Odd

[SimonBrandner]

LGTM otherwise. I have to admit that I've mostly skimmed through the CSS and the EventTile code. I am starting to understand why reviews can take a while sometimes 😅

[turt2live]

hey @su-ex can we get some screenshots in the PR description to make review easier? Thanks!

[turt2live]

@SimonBrandner now that your name is on the commits as well, we'll need signoff from you on here as well please.

[SimonBrandner]

@SimonBrandner now that your name is on the commits as well, we'll need signoff from you on here as well please.

Ah, true:

Signed-off-by: Šimon Brandner <[email protected]>

[su-ex]

@turt2live Sure, added! 📷

[nadonomy]

@su-ex thanks for cherry picking your commits & iterating on your implementation into this PR after the discussion we had on Matrix, really appreciated!

The PR principally looks good, but we need to do a bit of internal planning (with @gsouquet @amshakal & @jryans) on precisely how we'll iterate on this so will figure out some details with them before we approve/merge.

Relatedly, we wouldn't consider element-hq/element-web#4635 closed until we're closer to shipping this on production, including de-risking some cross-platform efforts, so I've edited your PR description to avoid this.

Thanks again for the effort!

[turt2live]

Thank you for the work on this, and sparking the idea of how it could work - we really appreciate it. We've picked up the idea over at #6291 and hope to land it soon from the looks of it.

In the meantime, closing this in favour of #6291 - thanks again for taking a stab at this.