Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Better handling for widgets that fail to load #6161

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jun 8, 2021

Nothing especially fancy:

Screenshot 2021-06-08 at 12 40 05

@dbkr dbkr requested a review from a team June 8, 2021 11:41
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm

if (this._sgWidget === null) {
appTileBody = (
<div className={appTileBodyClass} style={appTileBodyStyles}>
<AppWarning errorMsg="Error loading Widget" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translations?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah - I guess I'll change the mixed content one I copied it from too

And also the other one that I copied from
@dbkr dbkr merged commit 399be4f into develop Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants