This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Map phone number lookup results to their native rooms #6136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dialing a phone number, also look to see if there's a corresponding native user for the resulting user, and if so, go to the native room for that user.
Also fix as bug where we were checking the wrong field to check for native/virtual support: oops.
turt2live
suggested changes
Jun 3, 2021
|
@tomtom-78 @chagai95 are waiting for this to be merged - hope we get an email now when this is merged 😅 |
& use constant in test
turt2live
approved these changes
Jun 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dialing a phone number, also look to see if there's a corresponding
native user for the resulting user, and if so, go to the native room
for that user.
Also fix as bug where we were checking the wrong field to check
for native/virtual support: oops.
Move phone number dial handling into CallHandler rather than the DialPad component.