This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Improve styling of the message action bar #6066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refine UI of message action bar to increase usability and focus on bar content.
Increase size of buttons
t3chguy
reviewed
May 19, 2021
Correct error on css hover for message action button background colour change
t3chguy
changed the title
t3chguy
approved these changes
May 19, 2021
nadonomy
approved these changes
May 24, 2021
jryans
added a commit
that referenced
this pull request
Jun 2, 2021
This adjusts the `border-radius` used when hovering on an event to match the recently changed value for the action bar (changed to `8px` in #6066).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine UI of the message action bar to increase usability, focus on bar content, UI consistency.
Before:
After:
Increase focus on menu content by a) removing borders that were brighter than contents, making it slightly harder to see the icons and decide next steps; b) increasing size of buttons; c) changing background to not blend into the event tile hover
Increase UI consistency by a) reflecting other (recently made) lists of icons that don't use borders to separate iconography, see room header and composer options; b) using colour used for other icons
Increase usability by increasing the size of buttons and providing more feedback
Further notes
I took the opportunity to look at the action bar in Slack and Discord for reference.
This helped guide me to boost the size of the buttons, and use contrasting tones.
I did consider other options, like keeping the same button size, but the above examples made me want to propose a larger button.
My hope is to iterate this after trying it in the product for a week and when confident, use the styling to alter the message composer actions