Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Move SettingsStore watchers/monitors over to ES6 maps for performance #6063

Merged
merged 3 commits into from
May 25, 2021

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 19, 2021

Fixes element-hq/element-web#17369

Basic before&after of a 1 being typed into the room filter from empty on the same test account

Before 220ms
image

After 121ms
image

@t3chguy t3chguy requested a review from a team May 24, 2021 21:25
@t3chguy t3chguy marked this pull request as ready for review May 24, 2021 21:26
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐎 !

That's super interesting. Never really thought of the performance impact that objects can have versus Map. Do you have any interesting articles regarding the perf gains that they can provide?

@t3chguy
Copy link
Member Author

t3chguy commented May 25, 2021

I do not, I'm going off @turt2live's prior research where he got (iirc) an order of magnitude from moving js-sdk over to es6 maps for state etc

@t3chguy t3chguy merged commit 97c6ee3 into develop May 25, 2021
@t3chguy t3chguy deleted the t3chguy/fix/17369 branch May 25, 2021 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert SettingsStore watcher registry to maps
2 participants