Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Initial SpaceStore tests work #5906

Merged
merged 18 commits into from
Apr 27, 2021
Merged

Initial SpaceStore tests work #5906

merged 18 commits into from
Apr 27, 2021

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Apr 22, 2021

Fixes element-hq/element-web#17022

Fixes some edge case behaviours found by the testing

@t3chguy t3chguy marked this pull request as ready for review April 25, 2021 08:26
@t3chguy t3chguy requested a review from a team April 25, 2021 08:26
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this all looks great, thanks for adding this! 🤩 Seems like tests also found a few bugs...? Anyway, great work!

@t3chguy
Copy link
Member Author

t3chguy commented Apr 27, 2021

Seems like tests also found a few bugs...?

Yup, they definitely crushed some edge cases!

@t3chguy t3chguy merged commit 96e00ca into develop Apr 27, 2021
@t3chguy t3chguy deleted the t3chguy/fix/17022 branch April 27, 2021 12:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spaces write some tests
2 participants