Expand upon voice message event & include overall waveform #5888
Conversation
| throw new Error("Unable to create recorder: no worklet script registered"); | ||
| } | ||
| await this.recorderContext.audioWorklet.addModule(mxRecorderWorkletPath); | ||
| this.recorderWorklet = new AudioWorkletNode(this.recorderContext, WORKLET_NAME); |
There was a problem hiding this comment.
It seems like the AudioWorkletNode is not supported by Safari whereas the ScriptProcessorNode was.
Is there a fallback or progressive enhancement setup somewhere that I might not be aware of?
There was a problem hiding this comment.
ugh, I'll make note of this and get it properly tested in Safari in a future PR. I'm not confident it works properly before this change anyways.
There was a problem hiding this comment.
We'll definitely need some plan to support Safari before this can be enabled by default.
There was a problem hiding this comment.
plan is in progress, though is dependent on acquisition of a Mac (work in progress)
Co-authored-by: Germain <[email protected]>
| throw new Error("Unable to create recorder: no worklet script registered"); | ||
| } | ||
| await this.recorderContext.audioWorklet.addModule(mxRecorderWorkletPath); | ||
| this.recorderWorklet = new AudioWorkletNode(this.recorderContext, WORKLET_NAME); |
There was a problem hiding this comment.
We'll definitely need some plan to support Safari before this can be enabled by default.
This does two primary things:
There's no specification or MSC for what the
waveformattribute would contain, so this assumes that "one sample per second" is suitable. This is highly likely to change as a 1 second clip is likely to need a few dozen more samples.Note that this mixes in a couple MSCs to the event format. This is part of an experiment to see how it ends up working out.
Requires element-hq/element-web#17013