Labs: Add quick/cheap "do not disturb" flag #5873
Conversation
This just disables audio notifications and the popup, which is the easiest way to do "do not disturb" for a device. This needs spec changes to be done properly, as it's a shame that mobile devices for the user will still go off. Disabling all of push doesn't sound ideal as it would potentially mean missing highlights for when leaving DND mode.
| @@ -383,6 +383,10 @@ export const Notifier = { | |||
| // don't bother notifying as user was recently active in this room | |||
| return; | |||
| } | |||
| if (SettingsStore.getValue("doNotDisturb")) { | |||
There was a problem hiding this comment.
this should probably also check the feature is enabled to not lock a user into dnd
There was a problem hiding this comment.
the only way to get access to it though is through the feature flag though? If someone goes through devtools and changes it, that's kinda their fault (the devtools don't prevent someone from making mistakes).
There was a problem hiding this comment.
I mean if they end up disabling the lab this option should be implicitly disabled as it'll be very unclear why they are missing their notifications
There was a problem hiding this comment.
I suppose, though overall the labs feature system isn't entirely meant to have safety nets given we don't usually want people to be playing around in there...
Have opened element-hq/element-web#17000 in any case
|
IncompatibleController is one such safetynet but is the inverse of the required behaviour unfortunately |
This just disables audio notifications and the popup, which is the easiest way to do "do not disturb" for a device. This needs spec changes to be done properly, as it's a shame that mobile devices for the user will still go off.
Disabling all of push doesn't sound ideal as it would potentially mean missing highlights for when leaving DND mode.
Paired with element-hq/element-web#16962
Reviewer: This is without design/product review, hence labs flag. It's largely expected to just fall into the bucket of ancient labs flags for now.
Context for this PR: New personal workflow could do with some quiet time.