This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Properly disable composer access when recording a voice message #5870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
force-pushed
the
travis/voice/disable-composer
branch
from
6359caa to
fedb5b9
Compare
dbkr
approved these changes
Apr 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits recording management out to a store instead of using callbacks through the components, given more and more components will want to watch for voice recording updates. This then re-routes the
disabledflag through to the composer to properly disable itself.The composer text entry otherwise looks exactly the same when disabled versus not. We prevent all efforts we can to have people accidentally end up in the composer, but don't stop them if they somehow get in there - there's not much value to making absolutely sure someone can't send a message.
Reviewer: This is reviewable commit-by-commit (recommended)
Screenshot which looks eerily like the existing setup:
