-
-
Notifications
You must be signed in to change notification settings - Fork 829
Conversation
This adjusts the display of invite reasons to match design feedback. Fixes element-hq/element-web#16869
The contrast on |
Updated to remove blur effect after discussing with @niquewoodhouse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. Can iterate after feedback/shipping, eg add avatar/blur/etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than some naming nits
top: 0; | ||
bottom: 0; | ||
left: 0; | ||
right: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if you already know that, but I've only discovered this recently. There's now a shorthand for all those properties, inset
top: 0; | |
bottom: 0; | |
left: 0; | |
right: 0; | |
inset: 0; |
I believe PostCSS should do its job and replace that in the final bundle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though empirically PostCSS does not translate it
Looks like we'd need to install https://www.npmjs.com/package/postcss-inset if we wanted that
Given lack of Safari support https://developer.mozilla.org/en-US/docs/Web/CSS/inset we should not use it without postcss support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to inset
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jryans probably best to revert that to not risk it breaking under Safari
This adjusts the display of invite reasons to match design feedback.
Fixes element-hq/element-web#16869