Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Resizable CallView #5710

Merged
merged 15 commits into from
Apr 7, 2021
Merged

Resizable CallView #5710

merged 15 commits into from
Apr 7, 2021

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Mar 2, 2021 •
edited
Loading

Fixes #15876

Peek 2021-03-03 17-12

@SimonBrandner
Pass resizeNotifier into CallViewForARoom
4e9d19d 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Remove maxHeight prop
69cdbef 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Add resize CallViewForRoom CSS
f86e6fe 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Add CallViewForRoom
a3f7e5f 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Add resizing
5877b3e 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Fix CSS to make it work with resizing
2e535d2 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Don't use onResize
d244ea3 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Fix local feed size
0e5297f 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Remove unused consts
c638ced 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner SimonBrandner marked this pull request as ready for review March 3, 2021 16:17
@SimonBrandner
Increase minHeight
35a5442 
This is needed for on hold. Otherwise it feels like too much, tbc

Signed-off-by: Šimon Brandner <[email protected]>
@turt2live turt2live requested review from a team March 7, 2021 19:58
dbkr
dbkr reviewed Mar 8, 2021
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this will be super useful. Could someone who knows more about the resizers take a look at this as well?

@dbkr dbkr requested a review from a team March 8, 2021 13:55
@SimonBrandner SimonBrandner mentioned this pull request Mar 13, 2021
Merged
turt2live
turt2live approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resizer bit looks fine, sorry it took so long to review (I assumed Dave's avatar meant he was looking at it - oops). The little bit of linting/member access bits are all I'd ask to be fixed.

src/components/views/voip/CallViewForRoom.tsx Outdated Show resolved Hide resolved
@SimonBrandner
Make functions private
b257c25 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Add semicolons
9a2036c 
Signed-off-by: Šimon Brandner <[email protected]>
turt2live
turt2live approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marking approved for code changes

@niquewoodhouse
Copy link
Contributor

Just to confirm please, this is to resize the callview only when you're within the room, not the callview when its floating bottom right and you're not in that room?

@SimonBrandner
Copy link
Contributor Author

Just to confirm please, this is to resize the callview only when you're within the room, not the callview when its floating bottom right and you're not in that room?

Yes, this is only within the room, not the PIP call view

niquewoodhouse
niquewoodhouse approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@niquewoodhouse niquewoodhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. It's using the same styles as resize elsewhere in the product, so makes total sense as a starting point to iterate after shipping, if necessary.
Thanks for this improvement!

@turt2live turt2live merged commit 6e6a26f into matrix-org:develop Apr 7, 2021
@SimonBrandner SimonBrandner deleted the resizable-call-view branch July 3, 2021 10:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@turt2live turt2live turt2live approved these changes

@dbkr dbkr dbkr left review comments

@niquewoodhouse niquewoodhouse niquewoodhouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resizeable call UI
4 participants
@SimonBrandner @niquewoodhouse @dbkr @turt2live