This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add url param defaultUsername to prefill the login username field
#5674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djschilling
force-pushed
the
default-username
branch
2 times, most recently
from
409e19c to
96df810
Compare
|
@djschilling In general, it's quite hard to review a random PR like this without the motivation. There might be many other ways to solve the problem. Could you file an issue about the use case, so we can track that separate from this one possible solution? |
|
@jryans you are right my bad. i now created the issue for this pull request: element-hq/element-web#16573 |
|
@jryans can you have another look at it? |
jryans
suggested changes
Apr 20, 2021
Signed-off-by: David Schilling <[email protected]>
djschilling
force-pushed
the
default-username
branch
from
96df810 to
5c67436
Compare
jryans
reviewed
May 28, 2021
There was a problem hiding this comment.
The code here looks okay to me, but before approving I'd like to understand your comment that the username is not removed from the URL for you. See my new comment in the thread.
jryans
approved these changes
Jun 1, 2021
aaronraimist
added a commit
to aaronraimist/riot-web
that referenced
this pull request
Jul 23, 2021
defaultUsername was added in matrix-org/matrix-react-sdk#5674. I'm not aware of any others but they may exist. Signed-off-by: Aaron Raimist <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the possibility to provide a default username as url parameter
defaultUsernamefor the login forumlar.Fixes element-hq/element-web#16573