Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add <input type="password"> to security key field #5534

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Add <input type="password"> to security key field #5534

merged 1 commit into from
Jan 11, 2021

Conversation

SimonBrandner
Copy link
Contributor

This fixes #16071

Screenshot_20210105_131946

@SimonBrandner
Fixed 16071
247bd09 
Signed-off-by: SimonBrandner <[email protected]>
@t3chguy t3chguy requested a review from a team January 5, 2021 12:42
jryans
jryans approved these changes Jan 11, 2021
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes sense to me, and I believe the original designs intended for this all along. 😄

@jryans jryans merged commit 77f79e5 into matrix-org:develop Jan 11, 2021
@SimonBrandner SimonBrandner deleted the fix-16071 branch January 11, 2021 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security key text field really needs <input type="password">
2 participants
@SimonBrandner @jryans