Fix avatar upload prompt/tooltip floating wrong and permissions #5526
Conversation
| <div className={classNames("mx_Tooltip", { | ||
| "mx_Tooltip_visible": visible, | ||
| "mx_Tooltip_invisible": !visible, | ||
| })}> |
There was a problem hiding this comment.
it's a bit of a smell if we're ripping classes out of a component just to use them here. Can we make it a render mode of the Tooltip to do the work for us?
There was a problem hiding this comment.
We could but it'd make it an even more confusing component and we need to rebuild out Tooltips altogether as it is
There was a problem hiding this comment.
I'm a bit torn because this is the sort of thing that we should probably avoid making worse, but the situation is so bad that it's on a shortlist of options.
@jryans might be best to review this
There was a problem hiding this comment.
The issues are quite annoying visually, so I think it's better to accept this change and then revisit tooltips holistically later.
| <div className={classNames("mx_Tooltip", { | ||
| "mx_Tooltip_visible": visible, | ||
| "mx_Tooltip_invisible": !visible, | ||
| })}> |
There was a problem hiding this comment.
The issues are quite annoying visually, so I think it's better to accept this change and then revisit tooltips holistically later.
Fixes element-hq/element-web#15832
Fixes element-hq/element-web#16016
Fixes element-hq/element-web#16103
Visually identical, but without the bugs.