Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Specify community description img must be mxc urls #5364

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

mkenigs
Copy link
Contributor

@mkenigs mkenigs commented Oct 28, 2020

Closes element-hq/element-web#7100

Signed-off-by: Matthew Kenigsberg [email protected]

Closes #2856

@jryans jryans requested review from a team October 29, 2020 12:07
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine code-wise, though we might not want to put much effort into this broken feature until it is replaced from a product perspective.

@mkenigs
Copy link
Contributor Author

mkenigs commented Nov 18, 2020

So worth merging or too much work on a broken feature? @turt2live

@turt2live
Copy link
Member

it means that I can't make the call and require a deisgner/product person to look at this.

Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the current communities implementation is on the chopping block, seems harmless to merge this for legacy.

@turt2live turt2live merged commit df6218e into matrix-org:develop Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Community description, specify that <img> tags require a Matrix URL
3 participants