This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Modal Widgets - MSC2790 #5252
Merged
Modal Widgets - MSC2790 #5252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
… t3chguy/feat/modal-widgets
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
… t3chguy/feat/modal-widgets � Conflicts: � src/@types/global.d.ts
… t3chguy/feat/modal-widgets � Conflicts: � src/@types/global.d.ts � src/FromWidgetPostMessageApi.js � src/WidgetMessaging.js � src/widgets/WidgetApi.ts
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
… t3chguy/feat/modal-widgets
turt2live
approved these changes
Oct 22, 2020
Comment on lines
+98
to
+102
| // Add in some legacy support sprinkles (for non-popout widgets) | ||
| // TODO: Replace these with proper widget params | ||
| // See https://github.com/matrix-org/matrix-doc/pull/1958/files#r405714833 | ||
| parsed.searchParams.set('widgetId', this.widget.id); | ||
| parsed.searchParams.set('parentUrl', window.location.href.split('#', 2)[0]); |
There was a problem hiding this comment.
mostly for my notes: a lot of this is copied from SGWidget, but that's going away with the stuff I'm doing. Will need to refactor this a bit.
nadonomy
approved these changes
Oct 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adhoc build: https://riots.im/adhoc/modal-widgets3/
Requires matrix-org/matrix-widget-api#3
Sample widgets at https://github.com/vector-im/element-web/compare/t3chguy/feat/modal-widgets
Instructions:
Click me to show a modal widgetbutton