This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Support creation of Jitsi widgets with "openidtoken-jwt" auth #5173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks for auth needed by looking up a well-known file from the preferred Jitsi domain. No file existing will assume no auth.
If the Jitsi server we're using for a Jitsi conference call has auth of "openidtoken-jwt" then instead of a random human readable room ID, encode the room ID in base32 (without padding). This can then be decoded back to the room ID on the Jitsi end of things.
So we don't have to fetch the auth type when joining the conference.
Also add roomId to the widget data and URL template. It's needed by the Element Web Jitsi code to produce auth for the Jitsi backend.
t3chguy
reviewed
Sep 7, 2020
turt2live
suggested changes
Sep 7, 2020
* drop room ID from jitsi widget data * reame queryParts variable
As they're only set in the constructor.
turt2live
added
the
X-Release-Blocker
turt2live
approved these changes
Sep 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the react-sdk parts for supporting Synapse OpenID token based auth for Jitsi widgets. This auth enables locking Jitsi widgets to particular homeserver users and rooms. The whole flow is described here: https://github.com/matrix-org/prosody-mod-auth-matrix-user-verification
The auth flow is only used when the Jitsi server has a well-known file indicating the requirement of auth.
Element Web PR side for the Jitsi widget code PR: element-hq/element-web#15114