-
-
Notifications
You must be signed in to change notification settings - Fork 830
Add option to send/edit a message with Ctrl + Enter / Command + Enter #5160
Conversation
#1966 was a pull request which did this and was basically shut due to lack of product review. Fixes element-hq/element-web#5006 Don't edit i18n files other than en_EN otherwise your PR will create a conflict in Weblate. |
5e10fba
to
e842832
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@czeidler can you post a screenshot of settings and/or link to an ad hoc build to aid review please? Thanks!
7358ec8
to
8f655b0
Compare
When editing multi-line text this option helps to prevent accidentally sending a message too early. With this option, Enter just inserts a new line. For example, composing programming code in a dev chat becomes much easier when Enter just inserts a new line instead of sending the message. Signed-off-by: Clemens Zeidler <clemens.zeidler@gmail.com>
8f655b0
to
9031c58
Compare
Can you update the screenshot. Also please avoid force pushing once a review has already been made. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise, just small styling nit
Co-authored-by: Michael Telatynski <7t3chguy@googlemail.com>
Thanks! |
Will it be possible to set this setting to |
Yes. All setting defaults can be changed in the config. https://github.com/vector-im/element-web/blob/develop/docs/config.md |
Okay, I thought only the settings listed in UiFeatures could be set in So for my use case I can add : "settingDefaults": {
"MessageComposerInput.ctrlEnterToSend": true
} in my config.json. |
Fixes element-hq/element-web#5006
When editing multi-line text this option helps to prevent accidentally
sending a message too early. With this option, Enter just inserts a new
line.
For example, composing programming code in a dev chat becomes much
easier when Enter just inserts a new line instead of sending the
message.
Signed-off-by: Clemens Zeidler clemens.zeidler@gmail.com