This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Remove create-react-class #5157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't against |
|
It's staged against my other pr which removes stale components |
There was a problem hiding this comment.
Damn, that was thorough. I'm so happy about this.
It largely looks good to me. Just a few questions about the continued use of UNSAFE react lifecycle methods. And a few other curiosities.
I found it really hard to verify that all methods were correctly converted to either unbound functions or closures because of GH's review ui. However, the majority of cases were intuitive.
I'm happy with it but I guess we may also wait for some more eyes, such at turt2live's?
JorikSchellekens
approved these changes
Sep 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.