Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Update create room dialog copy & community prototype home icon #5151

Merged
merged 3 commits into from
Aug 28, 2020

Conversation

turt2live
Copy link
Member

Prototype behaviour:

  • The house looks more like a house.
    • Rationale: It's a house.
  • Slight copy change when creating a room in a community (see last screenshot)
    • Rationale: Reinforces that the room is for the community

Home icon:
image
image

Copy changes (regardless of prototype):
image
image
image

Copy changes (when creating rooms in the communities prototype):
image

@turt2live turt2live requested review from niquewoodhouse and a team August 27, 2020 19:54
Copy link
Contributor

@niquewoodhouse niquewoodhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @turt2live, just a bit unsure about this one:

91488340-65c8ec80-e86c-11ea-86ce-943958fdac26
I think there's an unnecessary word "be" after "only". I'd remove that, and the word "setting" in the last sentence.

Will "localhost" be an actual homeserver's name? If not, I'd suggest using homeserver in both the heading and the body, because now one says "localhost" and the other says "homeserver" so it's a bit hard to understand if these are the same thing/what they mean.

@turt2live
Copy link
Member Author

Localhost will in fact be the homeserver name

@turt2live turt2live merged commit 52e095f into develop Aug 28, 2020
@turt2live turt2live deleted the travis/copy-change branch August 28, 2020 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants