-
-
Notifications
You must be signed in to change notification settings - Fork 829
Conversation
MSC: matrix-org/matrix-spec-proposals#2448 While the image loads, we can show a blurred version of it (calculated at upload time) so we don't have a blank space in the timeline.
self-selecting this as a community PR as it's p2 relative to other work. |
@turt2live Has Product been alerted to this idea? If not, I think we either need a review from them, or it needs to be behind a labs flag. |
@jryans it definitely doesn't need a labs flag imo, but product and design will need to provide input at some point. Currently this is relatively low priority as it's an MSC implementation and not finalized yet, so it's already serving its intended purpose. I'll take this out of the review queue as it's somewhat failed to get review, and I don't expect/anticipate it to land anytime soon anyways. |
… travis/blurhash � Conflicts: � package.json � src/components/views/messages/MImageBody.js � yarn.lock
So this PR has only a subset of the support for MSC2448
Not yet done:
|
In all honesty, those missing areas were deliberately out of scope for this PR |
I was just summarising the current state. |
… travis/blurhash � Conflicts: � package.json � src/ContentMessages.tsx � yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great to me! There's some amount of updating to do to resolve conflicts, but otherwise it looks good. 😄
… travis/blurhash � Conflicts: � src/ContentMessages.tsx � src/components/structures/UploadBar.tsx � src/components/views/messages/MImageBody.js � src/components/views/messages/MStickerBody.js � src/components/views/messages/MVideoBody.tsx
MSC: matrix-org/matrix-spec-proposals#2448
While the image loads, we can show a blurred version of it (calculated at upload time) so we don't have a blank space in the timeline.
Example:
Done with a community hat on: