This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Implement new design on security setup & login #4831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although passphrase / passphrase confirm is still split between two screens because that's more work to change and probably is not a pivotal part of the UI that needs to change in step with everything else.
No reset option here anymore
turt2live
reviewed
Jun 25, 2020
src/async-components/views/dialogs/secretstorage/CreateSecretStorageDialog.js
Outdated
Show resolved
Hide resolved
| @@ -259,22 +284,15 @@ export default class CreateSecretStorageDialog extends React.PureComponent { | |||
| await cli.bootstrapSecretStorage({ | |||
| authUploadDeviceSigningKeys: this._doBootstrapUIAuth, | |||
| createSecretStorageKey: async () => this._recoveryKey, | |||
| setupNewKeyBackup: this.state.useKeyBackup, | |||
| setupNewKeyBackup: true, | |||
There was a problem hiding this comment.
do we not support this option anymore?
There was a problem hiding this comment.
This will shortly be part of dialog for setting up SSSS rather than cross-signing, so you'll either set up both SSSS storage and key backup or neither, as they're both basically server-side key backup. They'll be independent of cross-signing.
src/async-components/views/dialogs/secretstorage/CreateSecretStorageDialog.js
Outdated
Show resolved
Hide resolved
so they're a sensible colour in other themes
nadonomy
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
@dbkr these are looking great. We could do with some more padding between the icons & titles, and the icons/titles & micro copy in the radio interactions. Approving for now to avoid bitrot but lmk if you want to fix these before merging or not— happy to jump on a call to pixel tweak together at runtime.
|
[screenshot updated] |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the new designs for choosing between passphrase and recovery key, and entering the passphrase/key. We wanted these to land together so I've bundled the changes together, but kept the changes to key entry fairly minimal and cosmetic. Most notably, they still appear in a separate dialog on top of the original rather than being in the same dialog. I've also split other bits like the 'show passphrase' eye icon and moving the passphrase & conform boxes onto the same screen out to separate bugs.
Setting up:
Logging in:
(I'll add the placeholder when adding the upload button)
Also adds a border to the radio buttons on the appearance tab because they share a component and the one for the security screen needed a border:
Fixes element-hq/element-web#13825