Refactor MessageActions using ARIA Toolbar pattern #4799
Conversation
Signed-off-by: Mike Pennisi <[email protected]>
Signed-off-by: Mike Pennisi <[email protected]>
That issue is about the per-Message Actions Bar which has React, Reply, Edit, More Options |
|
Got it. I've submitted gh-4827 to hopefully provide the desired fix. For this patch, is there anyone we should contact to help make a decision? |
|
I would suggest chatting with the AT users in https://matrix.to/#/#a11y:riot.ovh as to what they'd find most obvious |
|
Oh, that's great! I'll follow up there |
|
@jugglinmike Does #4827 replace this one, or are they both meant to be reviewed...? |
|
Hi @jryans! This patch is independent, so it's still fit for review. That said, since it wasn't what was requested in element-hq/element-web#11316, so @t3chguy and I have been talking with folks in the Matrix room mentioned above. At least one person's on board, though to be honest, I don't know the criteria for moving forward with this patch. |
|
Can you do a DCO sign-off in the PR description as one of your commits lacks one, thanks :) |
| <UploadButton key="upload" | ||
| tabIndex={tabIndex('upload')} | ||
| roomId={props.room.roomId} />, | ||
| <EmojiButton key="emoji" | ||
| tabIndex={tabIndex('emoji')} | ||
| addEmoji={addEmoji} />, | ||
| <Stickerpicker key="sticker" | ||
| tabIndex={tabIndex('sticker')} | ||
| room={props.room} />, |
There was a problem hiding this comment.
our multi-line props style is to do 4 space indent on the line after the component opener
| <CallButton key="call" | ||
| tabIndex={tabIndex('call')} | ||
| roomId={props.room.roomId} />, | ||
| <VideoCallButton key="videocall" | ||
| tabIndex={tabIndex('videocall')} | ||
| roomId={props.room.roomId} />, |
| <HangupButton key="hangup" | ||
| tabIndex={tabIndex('hangup')} | ||
| roomId={props.room.roomId} />, |
Sure, although I don't intend for this branch to be merged as a series of distinct commits. Let me know if you would rather thatI squash them down on my end. |
|
Thanks for making this contribution a while back. Since the code base has changed since this was opened, it no longer applies cleanly, and I don't think there's a need to keep it open in this state, as we can always find the code here again if needed. If you are still interested in pursuing this feature, please discuss with us in #element-dev:matrix.org to find a good approach forward. |
This patch includes two commits to help reviewers distinguish between code reorganization and new implementation.
I haven't been able to test the alternate layout for "call in progress" because I don't have any contacts yet.
Signed-off-by: Mike Pennisi [email protected]