This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add DM rooms with that person to the MemberInfo panel #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factor out the chunk of code that looks through a read receipt event to see if it contain a read receipt from a given user, now we use it in 2 places.
| // because if we read a notification, it will affect notification count | ||
| // only bother updating if there's a receipt from us | ||
| if (Receipt.findReadReceiptFromUserId(receiptEvent, MatrixClientPeg.get().credentials.userId)) { | ||
| this.forceUpdate(); |
There was a problem hiding this comment.
why does MemberInfo care about RRs?
There was a problem hiding this comment.
It doesn't really, it's just the same optimisation used in RoomList that we can skip updating if the read receipt is not from us because we only show the read count.
|
lgtm other than one Q |
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 3 of element-hq/element-web#2099
Fixes element-hq/element-web#1477
Requires element-hq/element-web#2147